feat: update public account retrieval #1591
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lic-account-retrieval
fkrause98
requested review from
SantiagoPittella and
igamigo
and removed request for
igamigo
fkrause98
added
no changelog
igamigo
reviewed
Jan 14, 2026
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "tonic")] |
Collaborator
There was a problem hiding this comment.
Is this needed? It does not seem to be needed in any of the other conversions
Comment on lines
+400
to
+402
| // Builds an account that triggers the "too_many_assets" boolean | ||
| // flag when requested from the node. | ||
| fn build_test_faucets_and_account() -> anyhow::Result<Vec<Account>> { |
Collaborator
There was a problem hiding this comment.
If possible, would be great to break this function into smaller ones to make this more readable. Alternatively (or maybe as a complement), would be great to add small comments within the function
Comment on lines
+108
to
+110
| /// Given an id, return the proof for the account. | ||
| /// If the account also has public state, the details for it | ||
| /// will also be retrieve as part of the proof. |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// Given an id, return the proof for the account. | |
| /// If the account also has public state, the details for it | |
| /// will also be retrieve as part of the proof. | |
| /// Given an [`AccountId`], return the proof for the account. | |
| /// | |
| /// If the account also has public state, the details for it will also be retrieved as part of | |
| /// the proof. |
| info | ||
| } else { | ||
| let fetched_data = | ||
| self.sync_storage_maps(0_u32.into(), None, account_id).await?; |
Collaborator
There was a problem hiding this comment.
I think we still need to implement pagination in GrpcClient::sync_storage_maps and GrpcClient::sync_storage_vaults, right?
Comment on lines
+68
to
+71
| // Helper function to request extra details for an account. | ||
| // Keep in mind, this can potentially do **two** requests to the rpc endpoint. | ||
| // If the account has a non public state, it will simply return the first response. | ||
| // Otherwise it will request the RPC endpoint for the extra data for an account with public state. |
Collaborator
There was a problem hiding this comment.
These comments look misplaced
| // Keep in mind, this can potentially do **two** requests to the rpc endpoint. | ||
| // If the account has a non public state, it will simply return the first response. | ||
| // Otherwise it will request the RPC endpoint for the extra data for an account with public state. | ||
|
|
Collaborator
There was a problem hiding this comment.
Suggested change
| .get_account_proof(account_request) | ||
| .await | ||
| .map_err(|status| { | ||
| RpcError::from_grpc_error(NodeRpcClientEndpoint::GetAccountDetails, status) |
Collaborator
There was a problem hiding this comment.
This should be renamed to something like NodeRpcClientEndpoint::GetAccount or something like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: #1563.
There's a (currently open) PR for miden-node that unifies the "GetAccountDetails" and "GetAccountProofs endpoints" into a single endpoint "GetAccount". The goal of this PR is to adapt to said new endpoint, while preserving the actual NodeRpcClient trait API.
We will probably have to wait for said PR to be merged to be merged. Since I've encountered some versioning issues while working with this, so I'm currently using a local setup for this to work.
Also, something important is that the new protobuf structures have changed quite a bit, so there are probably some
parameters I might've missed or that we should decide on how to handle them.
Tasks Left: